Enable new linters #1162

ELENAGER · 2023-12-11T12:32:39Z

No description provided.

raghavendra-talur

2 of the commits look good(errname and removal of deprecated linters).

For the commit that fixes the unused-parameters, I suggest the following:

If the function is a method(or part of a interface), do what you have done.
If it is not a method, then don't use the _ method but remove the parameter from the function signature altogether and change the caller too.

raghavendra-talur · 2023-12-18T21:53:30Z

controllers/drplacementcontrol_controller_test.go

@@ -191,7 +191,7 @@ func getSyncDRPolicy() *rmn.DRPolicy {
 var drstate string

 // FakeProgressCallback of function type
-func FakeProgressCallback(drpcName string, state string) {
+func FakeProgressCallback(_ string, state string) {


Can remove this parameter.

It must have specific signature:
// ProgressCallback of function type
type ProgressCallback func(string, string),

raghavendra-talur · 2023-12-18T21:54:24Z

controllers/vrg_kubeobjects.go

@@ -168,8 +168,8 @@ func (v *VRGInstance) kubeObjectsCaptureStartOrResumeOrDelay(
 }

 func kubeObjectsCaptureStartConditionallySecondary(
-	v *VRGInstance, result *ctrl.Result,
-	captureStartGeneration int64, captureStartTimeSince, captureStartInterval time.Duration,
+	v *VRGInstance, _ *ctrl.Result,


Can remove these parameters.

This function must have a signature:
captureStartConditionally func(*VRGInstance, *ctrl.Result, int64, time.Duration, time.Duration, func())

raghavendra-talur · 2023-12-18T21:54:33Z

controllers/vrg_kubeobjects.go

@@ -187,7 +187,7 @@ func kubeObjectsCaptureStartConditionallySecondary(

 func kubeObjectsCaptureStartConditionallyPrimary(
 	v *VRGInstance, result *ctrl.Result,
-	captureStartGeneration int64, captureStartTimeSince, captureStartInterval time.Duration,
+	_ int64, captureStartTimeSince, captureStartInterval time.Duration,


This one too.

This function must have a signature:
captureStartConditionally func(*VRGInstance, *ctrl.Result, int64, time.Duration, time.Duration, func())

raghavendra-talur · 2023-12-18T21:54:59Z

controllers/vrg_volrep_test.go

@@ -1788,14 +1788,14 @@ func pvcUnprotectedVerify(
 type pvcPreDeleteVerify func(ramendrv1alpha1.VolumeReplicationGroup, types.NamespacedName, string)

 func vrgPvcStatusAbsentVerify(
-	vrg ramendrv1alpha1.VolumeReplicationGroup, pvcNamespacedName types.NamespacedName, pvName string,
+	vrg ramendrv1alpha1.VolumeReplicationGroup, pvcNamespacedName types.NamespacedName, _ string,
 ) {


This function must have signature:
type pvcPreDeleteVerify func(ramendrv1alpha1.VolumeReplicationGroup, types.NamespacedName, string)

raghavendra-talur · 2023-12-18T21:55:03Z

controllers/vrg_volrep_test.go

 ) {
 	By("not storing PVC in VRG's status")
 	Expect(vrgController.FindProtectedPVC(&vrg, pvcNamespacedName.Namespace, pvcNamespacedName.Name)).To(BeNil())
 }

 func pvcClusterDataProtectedFalseVerify(
-	vrg ramendrv1alpha1.VolumeReplicationGroup, pvcNamespacedName types.NamespacedName, pvName string,
+	vrg ramendrv1alpha1.VolumeReplicationGroup, pvcNamespacedName types.NamespacedName, _ string,


This function must have signature:
type pvcPreDeleteVerify func(ramendrv1alpha1.VolumeReplicationGroup, types.NamespacedName, string)

raghavendra-talur · 2023-12-18T21:55:07Z

controllers/vrg_volrep_test.go

@@ -1835,7 +1835,7 @@ func pvcClusterDataProtectedStatusVerify(

 type pvcPostDeleteVerify func(types.NamespacedName, string)

-func vrAndPvcDeletionTimestampsRecentVerify(pvcNamespacedName types.NamespacedName, pvName string) {
+func vrAndPvcDeletionTimestampsRecentVerify(pvcNamespacedName types.NamespacedName, _ string) {


This function must have signature:
type pvcPreDeleteVerify func(ramendrv1alpha1.VolumeReplicationGroup, types.NamespacedName, string)

raghavendra-talur · 2023-12-18T21:56:42Z

controllers/drcluster_controller.go

@@ -449,7 +449,7 @@ func validateCIDRsFormat(drcluster *ramen.DRCluster, log logr.Logger) error {
 	return nil
 }

-func (r DRClusterReconciler) processDeletion(u *drclusterInstance) (ctrl.Result, error) {
+func processDeletion(u *drclusterInstance) (ctrl.Result, error) {


I prefer to keep this as a method. You can probably remove the receiver like you have in other cases.

raghavendra-talur · 2023-12-18T21:59:20Z

controllers/drplacementcontrol.go

-	homeCluster := ""
-	homeClusterNamespace := ""
+	homeCluster = ""
+	homeClusterNamespace = ""


Can remove these lines as null value of string is empty string in go.

Signed-off-by: Elena Gershkovich <[email protected]>

ELENAGER force-pushed the uncomment_linters branch 5 times, most recently from 986b2a5 to daf93fe Compare December 11, 2023 13:58

raghavendra-talur requested changes Dec 11, 2023

View reviewed changes

ELENAGER force-pushed the uncomment_linters branch 3 times, most recently from 13901aa to f5c98d3 Compare December 13, 2023 11:45

ELENAGER requested a review from raghavendra-talur December 13, 2023 12:15

raghavendra-talur reviewed Dec 18, 2023

View reviewed changes

ELENAGER force-pushed the uncomment_linters branch 3 times, most recently from 36d3378 to 1544fe5 Compare December 19, 2023 10:04

ELENAGER force-pushed the uncomment_linters branch 2 times, most recently from 935ac2e to ed46af5 Compare December 27, 2023 12:11

ELENAGER requested a review from raghavendra-talur December 27, 2023 12:23

ELENAGER force-pushed the uncomment_linters branch 4 times, most recently from 74306f0 to ebc2060 Compare January 22, 2024 13:30

ELENAGER added 7 commits January 25, 2024 09:42

Enable errname linter - checks that errors are prefixed with the Err

bb7df42

Signed-off-by: Elena Gershkovich <[email protected]>

Remove deprecated linter flags

b06e807

Signed-off-by: Elena Gershkovich <[email protected]>

Enable unused-parameter revive flag

6cf6325

Signed-off-by: Elena Gershkovich <[email protected]>

Enable unused-receiver revive flag

836cc93

Signed-off-by: Elena Gershkovich <[email protected]>

Enable confusing-results revive flag

d466d29

Signed-off-by: Elena Gershkovich <[email protected]>

Enable bool-literal-in-expr revive flag

9cb41cc

Signed-off-by: Elena Gershkovich <[email protected]>

Enable confusing-naming revive flag

6452c50

Signed-off-by: Elena Gershkovich <[email protected]>

ELENAGER force-pushed the uncomment_linters branch from ebc2060 to ba24b63 Compare January 25, 2024 10:24

ELENAGER force-pushed the uncomment_linters branch 3 times, most recently from 1841da2 to 6452c50 Compare January 25, 2024 10:53

ShyamsundarR mentioned this pull request Mar 7, 2024

golangci: remove deprecated linters #1230

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable new linters #1162

Enable new linters #1162

ELENAGER commented Dec 11, 2023

raghavendra-talur left a comment

raghavendra-talur Dec 18, 2023

ELENAGER Dec 19, 2023 •

edited

Loading

raghavendra-talur Dec 18, 2023

ELENAGER Dec 19, 2023

raghavendra-talur Dec 18, 2023

ELENAGER Dec 19, 2023

raghavendra-talur Dec 18, 2023

ELENAGER Dec 19, 2023

raghavendra-talur Dec 18, 2023

ELENAGER Dec 19, 2023

raghavendra-talur Dec 18, 2023

ELENAGER Dec 19, 2023

raghavendra-talur Dec 18, 2023

ELENAGER Dec 19, 2023

raghavendra-talur Dec 18, 2023

ELENAGER Dec 19, 2023

Enable new linters #1162

Are you sure you want to change the base?

Enable new linters #1162

Conversation

ELENAGER commented Dec 11, 2023

raghavendra-talur left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ELENAGER Dec 19, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ELENAGER Dec 19, 2023 •

edited

Loading